build: enable UI tests on macOS via Tycho profile + JRE docs#1283
Merged
joaodinissf merged 1 commit intoMay 18, 2026
Conversation
joaodinissf
force-pushed
the
fix/start-on-first-thread
branch
from
faa451c to
7bce3ca
Compare
joaodinissf
force-pushed
the
fix/start-on-first-thread
branch
from
7bce3ca to
9973822
Compare
Collaborator
Author
|
Note to self: Test the launch configs on Windows before merging — |
joaodinissf
force-pushed
the
fix/start-on-first-thread
branch
from
9973822 to
d305681
Compare
joaodinissf
force-pushed
the
fix/start-on-first-thread
branch
2 times, most recently
from
86d7aad to
9f3063a
Compare
joaodinissf
force-pushed
the
fix/start-on-first-thread
branch
6 times, most recently
from
51088b6 to
8accb3d
Compare
joaodinissf
force-pushed
the
fix/start-on-first-thread
branch
from
8accb3d to
cfce73c
Compare
joaodinissf
changed the title
Add a `macosx` Maven profile in ddk-parent/pom.xml, activated on family=mac, that sets the OSGi target environment (macosx/cocoa/aarch64) and appends -XstartOnFirstThread to test.javaOptions. SWT on Cocoa requires the Display to be created on the main thread; without the flag, UI tests fail with "SWTException: Invalid thread access". The same flag is needed when developers run UI test launches from Eclipse on macOS, but -XstartOnFirstThread is rejected as an "Unrecognized VM option" by the JVM on Windows and Linux. Eclipse's own .launch files (e.g. in eclipse-platform/eclipse.platform) omit it entirely and rely on the launching JRE's default VM arguments to add it on macOS. Adopt the same pattern: document the one-time per-JRE setup in AGENTS.md instead of hardcoding the flag in cross-platform .launch files. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
joaodinissf
force-pushed
the
fix/start-on-first-thread
branch
from
cfce73c to
0b7a7cc
Compare
Collaborator
Author
Confirmed this doesn't work, pivoting the PR to something compatible instead. |
3 tasks
rubenporras
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables UI tests to run on macOS without modifying cross-platform
.launchfiles.Background
SWT on Cocoa requires the Display to be created on the main thread. UI tests on macOS need
-XstartOnFirstThread; without it they fail withSWTException: Invalid thread access. But the same flag is rejected asUnrecognized VM optionby the JVM on Windows and Linux.Approach
Following the same pattern as Eclipse Platform's own UI test launches (
eclipse-platform/eclipse.platform), which keep.launchfiles cross-platform and rely on per-developer JRE configuration for the macOS flag:mvn verify: a newmacosxprofile inddk-parent/pom.xml, activated onfamily=mac, sets the OSGi target environment (macosx/cocoa/aarch64) and appends-XstartOnFirstThreadtotest.javaOptions. No manual setup needed for CI.-XstartOnFirstThreadto their JRE's default VM arguments once (Window > Preferences > Java > Installed JREs > Edit > Default VM arguments). PDE launches withappend.args=true(all of ours) inherit it on macOS. Documented inAGENTS.md..launchfiles are not modified, so Windows and Linux developers see noUnrecognized VM optionregression.🤖 Generated with Claude Code